accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (ACCUMULO-4335) Error conditions that result in a Halt call should ensure non-zero process exit code
Date Thu, 09 Jun 2016 20:59:20 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15323341#comment-15323341
] 

Christopher Tubbs edited comment on ACCUMULO-4335 at 6/9/16 8:58 PM:
---------------------------------------------------------------------

Thanks [~busbey] for this fix! It's a good catch. I think we should do it for 1.6+; I can't
see how it would hurt. It may change the behavior of some scripts which launch the process,
but only in a good way of catching failed processes which previously went unnoticed, which
seems like it meets the definition of a bug fix to me.

(Note on version tagging in JIRA: it's generally safe to assume that bug which affect 1.6.5
also affect earlier versions, and I removed 2.0.0 from the fixVersion, because I think it's
generally implied that any fix in one "dot zero" release will also be in future "dot zero"
releases. This is my personal philosophy when triage'ing issues... but if we want to adopt
some other, more reasonable standard, we could do that, too.)


was (Author: ctubbsii):
Thanks [~busbey] for this fix! It's a good catch. I think we should do it for 1.6+; I can't
see how it would hurt. It may change the behavior of some scripts which launch the process,
but only in a good way of catching failed processes which previously went unnoticed, which
seems like it meets the definition of a bug fix to me.

(Note on version tagging in JIRA: it's generally safe to assume that bug which affect 1.6.5
also affect earlier versions, and I removed 2.0.0 from the fixVersion, because I think it's
generally implied that any fix in one "dot zero" release will also be in future "dot zero"
releases.)

> Error conditions that result in a Halt call should ensure non-zero process exit code
> ------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-4335
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4335
>             Project: Accumulo
>          Issue Type: Bug
>          Components: gc, tserver
>    Affects Versions: 1.6.5, 1.7.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>             Fix For: 1.8.0
>
>         Attachments: ACCUMULO-4335-1.8.v1.patch, ACCUMULO-4335.1.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> There are several places where we get some fatal error and exit with a 0 code, indicating
no error.
> e.g. when the TabletServer loses the ability to monitor zk.
> (this impacts 1.6.0+, but I can only select 1.6.5 from 1.6.z)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message