accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Marion (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4307) semver compliance maven plugin
Date Mon, 09 May 2016 20:20:13 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276948#comment-15276948
] 

Dave Marion commented on ACCUMULO-4307:
---------------------------------------

FWIW, it looks like it picks up changes well. There is an issue open (https://github.com/siom79/japicmp/issues/41)
where it does not handle generics in a super class well and marks the subclass with a change
named 'METHOD_ABSTRACT_ADDED_IN_SUPERCLASS'. Configuring it to only report binary incompatible
changes fixes it, but I'm not sure thats what we want. Ran it against 1.8.0-SNAPSHOT compared
to 1.7.1 and it looked ok.

> semver compliance maven plugin
> ------------------------------
>
>                 Key: ACCUMULO-4307
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4307
>             Project: Accumulo
>          Issue Type: New Feature
>          Components: build
>            Reporter: Dave Marion
>             Fix For: 1.6.6, 1.7.2, 1.8.0, 2.0.0
>
>
> Found https://siom79.github.io/japicmp/MavenPlugin.html today and tested it out. Was
wondering what thoughts are for incorporating this into the build. I tested it on 1.6.6-SNAPSHOT
by dropping the following into the test pom file:
> {noformat}
>     <profile>
>       <id>semver-compliance</id>
>       <build>
>         <plugins>
>           <plugin>
>             <groupId>com.github.siom79.japicmp</groupId>
>             <artifactId>japicmp-maven-plugin</artifactId>
>             <version>0.7.2</version>
>             <executions>
>               <execution>
>                 <id>client compliance</id>
>                 <goals>
>                   <goal>cmp</goal>
>                 </goals>
>                 <phase>verify</phase>
>                 <configuration>
>                   <oldVersion>
>                     <dependency>
>                       <groupId>org.apache.accumulo</groupId>
>                       <artifactId>accumulo-core</artifactId>
>                       <version>1.6.5</version>
>                       <type>jar</type>
>                     </dependency>
>                   </oldVersion>
>                   <newVersion>
>                     <dependency>
>                       <groupId>org.apache.accumulo</groupId>
>                       <artifactId>accumulo-core</artifactId>
>                       <version>${project.version}</version>
>                       <type>jar</type>
>                     </dependency>
>                   </newVersion>
>                   <parameter>
>                     <includes>
>                       <include>org.apache.accumulo.core.client</include>
>                       <include>org.apache.accumulo.core.data</include>
>                       <include>org.apache.accumulo.core.security</include>
>                     </includes>
>                     <excludes>
>                       <exclude>*crypto*</exclude>
>                       <exclude>*impl*</exclude>
>                       <exclude>*thrift*</exclude>
>                     </excludes>
>                     <accessModifier>protected</accessModifier>
>                     breakBuildBasedOnSemanticVersioning>true</breakBuildBasedOnSematicVersioning>
>                     <onlyModified>true</onlyModified>
>                   </parameter>
>                 </configuration>
>               </execution>
>             </executions>
>           </plugin>
>         </plugins>
>       </build>
>     </profile>
> {noformat}
>  I tried getting the previous release version number using the build-helper-maven-plugin,
but it found the wrong version. If we use this we would also have to include an execution
for minicluster and determine whether or not we want to use the reporting feature of the plugin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message