Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0F84D19904 for ; Sat, 16 Apr 2016 22:04:26 +0000 (UTC) Received: (qmail 75290 invoked by uid 500); 16 Apr 2016 22:04:25 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 75246 invoked by uid 500); 16 Apr 2016 22:04:25 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 75215 invoked by uid 99); 16 Apr 2016 22:04:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Apr 2016 22:04:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7001D2C1F56 for ; Sat, 16 Apr 2016 22:04:25 +0000 (UTC) Date: Sat, 16 Apr 2016 22:04:25 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-4192) Analyze Threading for Tracing correctness MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244428#comment-15244428 ] Josh Elser commented on ACCUMULO-4192: -------------------------------------- bq. I think the removal of that TraceRunnable was fixing a bug Sorry, I wasn't suggesting that we should reinstate it, but that we should check for {{Trace.wrap}} in the appropriate places. Would that cause more problems, [~billie.rinaldi]? I'm trying to remember the details of ACCUMULO-3507. > Analyze Threading for Tracing correctness > ----------------------------------------- > > Key: ACCUMULO-4192 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4192 > Project: Accumulo > Issue Type: Task > Components: trace > Reporter: Josh Elser > Priority: Blocker > Fix For: 1.7.2, 1.8.0 > > > When we switched from cloudtrace to htrace, we lost an implicit {{TraceRunnable}} wrapper in NamingThreadFactory (which is used by SimpleThreadPool). This results in the current Trace's span being lost across threads. > We should inspect uses of SimpleThreadPool (and maybe TraceRunnable in 1.6) to make sure that we don't have any other hidden tracing problems before the next 1.7 and 1.8 release. -- This message was sent by Atlassian JIRA (v6.3.4#6332)