accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4195) Generalized configuration object for Accumulo rfile interaction
Date Wed, 27 Apr 2016 18:49:13 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260733#comment-15260733
] 

ASF GitHub Bot commented on ACCUMULO-4195:
------------------------------------------

Github user mjwall commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/95#discussion_r61314805
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloFileOutputFormat.java
---
    @@ -186,7 +186,8 @@ public void write(Key key, Value value) throws IOException {
             }
     
             if (out == null) {
    -          out = FileOperations.getInstance().openWriter(file.toString(), file.getFileSystem(conf),
conf, null, acuConf);
    +          out = FileOperations.getInstance().newWriterBuilder().forFile(file.toString(),
file.getFileSystem(conf), conf).withTableConfiguration(acuConf)
    --- End diff --
    
    Didn't look too closely, but it struck me this could be cleaned up with another constructor
that took a Path and  Configuration so it would read
    `
    out = FileOperations.getInstance().newWriterBuilder().forFile(file, conf).withTableConfiguration(acuConf)
    `
    Fine as is though


> Generalized configuration object for Accumulo rfile interaction
> ---------------------------------------------------------------
>
>                 Key: ACCUMULO-4195
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4195
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Shawn Walker
>             Fix For: 1.8.0
>
>
> Taken from https://github.com/apache/accumulo/pull/90/files#r59489073
> On [~ShawnWalker]'s PR for ACCUMULO-4187 which adds rate-limiting on major compactions,
we noted that many of the changes were related to passing an extra argument (RateLimiter)
around through all of the code which is related to file interaction.
> It would be nice to move to a centralized configuration object instead of having to add
a new argument every time some new feature is added to the file-path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message