accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4195) Generalized configuration object for Accumulo rfile interaction
Date Wed, 27 Apr 2016 18:25:13 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260664#comment-15260664
] 

ASF GitHub Bot commented on ACCUMULO-4195:
------------------------------------------

Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/95#issuecomment-215182076
  
    Nice, I think these changes look good.
    
    `mvn verify -Psunny` also passed:
    ```
    [INFO] Reactor Summary:
    [INFO]
    [INFO] Apache Accumulo Project ............................ SUCCESS [  5.504 s]
    [INFO] Apache Accumulo Fate ............................... SUCCESS [ 45.591 s]
    [INFO] Apache Accumulo Start .............................. SUCCESS [01:08 min]
    [INFO] Apache Accumulo Core ............................... SUCCESS [03:59 min]
    [INFO] Apache Accumulo Server Base ........................ SUCCESS [02:12 min]
    [INFO] Apache Accumulo Tracer Server ...................... SUCCESS [ 22.325 s]
    [INFO] Apache Accumulo Shell .............................. SUCCESS [ 31.890 s]
    [INFO] Apache Accumulo Simple Examples .................... SUCCESS [ 19.693 s]
    [INFO] Apache Accumulo GC Server .......................... SUCCESS [ 16.644 s]
    [INFO] Apache Accumulo Master Server ...................... SUCCESS [ 27.389 s]
    [INFO] Apache Accumulo Monitor Server ..................... SUCCESS [ 21.547 s]
    [INFO] Apache Accumulo Tablet Server ...................... SUCCESS [ 58.315 s]
    [INFO] Apache Accumulo MiniCluster ........................ SUCCESS [01:23 min]
    [INFO] Apache Accumulo Native Libraries ................... SUCCESS [  4.775 s]
    [INFO] Apache Accumulo Proxy .............................. SUCCESS [01:05 min]
    [INFO] Apache Accumulo Trace .............................. SUCCESS [  6.256 s]
    [INFO] Apache Accumulo Iterator Test Harness .............. SUCCESS [  8.341 s]
    [INFO] Apache Accumulo Testing ............................ SUCCESS [13:16 min]
    [INFO] Apache Accumulo .................................... SUCCESS [  8.178 s]
    [INFO] Apache Accumulo Documentation ...................... SUCCESS [  0.415 s]
    [INFO] Apache Accumulo Maven Plugin ....................... SUCCESS [ 47.383 s]
    [INFO] ------------------------------------------------------------------------
    [INFO] BUILD SUCCESS
    [INFO] ------------------------------------------------------------------------
    [INFO] Total time: 28:31 min
    [INFO] Finished at: 2016-04-27T13:20:53-04:00
    [INFO] Final Memory: 94M/617M
    [INFO] ------------------------------------------------------------------------
    ```
    Any further comments @keith-turner before I merge this in?


> Generalized configuration object for Accumulo rfile interaction
> ---------------------------------------------------------------
>
>                 Key: ACCUMULO-4195
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4195
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Shawn Walker
>             Fix For: 1.8.0
>
>
> Taken from https://github.com/apache/accumulo/pull/90/files#r59489073
> On [~ShawnWalker]'s PR for ACCUMULO-4187 which adds rate-limiting on major compactions,
we noted that many of the changes were related to passing an extra argument (RateLimiter)
around through all of the code which is related to file interaction.
> It would be nice to move to a centralized configuration object instead of having to add
a new argument every time some new feature is added to the file-path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message