accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4195) Generalized configuration object for Accumulo rfile interaction
Date Wed, 27 Apr 2016 16:20:13 GMT


ASF GitHub Bot commented on ACCUMULO-4195:

Github user ShawnWalker commented on the pull request:
    I changed the method names to look more builder-ish as @joshelser suggested.  Wasn't quite
sure how the change the verbiage `getFileSize(...)`, so I left it alone.  
    I also dovetailled `NeedsFile` into `NeedsTableConfiguration`, cutting down the signature
of the factory methods somewhat.

> Generalized configuration object for Accumulo rfile interaction
> ---------------------------------------------------------------
>                 Key: ACCUMULO-4195
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Shawn Walker
>             Fix For: 1.8.0
> Taken from
> On [~ShawnWalker]'s PR for ACCUMULO-4187 which adds rate-limiting on major compactions,
we noted that many of the changes were related to passing an extra argument (RateLimiter)
around through all of the code which is related to file interaction.
> It would be nice to move to a centralized configuration object instead of having to add
a new argument every time some new feature is added to the file-path.

This message was sent by Atlassian JIRA

View raw message