accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4195) Generalized configuration object for Accumulo rfile interaction
Date Thu, 21 Apr 2016 17:39:25 GMT


ASF GitHub Bot commented on ACCUMULO-4195:

Github user ShawnWalker commented on a diff in the pull request:
    --- Diff: test/src/main/java/org/apache/accumulo/test/proxy/ ---
    @@ -2077,7 +2077,8 @@ public void bulkImport() throws Exception {
         // Write an RFile
         String filename = dir + "/bulk/import/rfile.rf";
    -    FileSKVWriter writer = FileOperations.getInstance().openWriter(filename, fs, fs.getConf(),
null, DefaultConfiguration.getInstance());
    +    FileSKVWriter writer = FileOperations.getInstance().openWriter().ofFile(filename,
fs, fs.getConf())
    +        .withTableConfiguration(DefaultConfiguration.getInstance()).execute();
    --- End diff --
    Within the Accumulo source, the only time that the "default" configuration is the right
answer is in tests.  Having `FileAccessOperations` provide the default configuration might
make writing some tests a tad easier, but at the cost of making it easier to write buggy functional

> Generalized configuration object for Accumulo rfile interaction
> ---------------------------------------------------------------
>                 Key: ACCUMULO-4195
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Shawn Walker
>             Fix For: 1.8.0
> Taken from
> On [~ShawnWalker]'s PR for ACCUMULO-4187 which adds rate-limiting on major compactions,
we noted that many of the changes were related to passing an extra argument (RateLimiter)
around through all of the code which is related to file interaction.
> It would be nice to move to a centralized configuration object instead of having to add
a new argument every time some new feature is added to the file-path.

This message was sent by Atlassian JIRA

View raw message