accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4195) Generalized configuration object for Accumulo rfile interaction
Date Mon, 18 Apr 2016 20:25:25 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246465#comment-15246465
] 

Josh Elser commented on ACCUMULO-4195:
--------------------------------------

I just made a quick pass over the diff from your pull request, maybe some sort of {{FileOperationsOptions}}
that just wraps a Hadoop {{Configuration}} and the Accumulo {{AccumuloConfiguration}} and
{{RateLimiter}} would be the way to start?

We probably don't have good enough internal APIs to really separate the "caller-specific"
details presently (your examples are a great point). Maybe we can just consolidate what is
general enough to not have to worry about what the method is actually doing?

> Generalized configuration object for Accumulo rfile interaction
> ---------------------------------------------------------------
>
>                 Key: ACCUMULO-4195
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4195
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Shawn Walker
>             Fix For: 1.8.0
>
>
> Taken from https://github.com/apache/accumulo/pull/90/files#r59489073
> On [~ShawnWalker]'s PR for ACCUMULO-4187 which adds rate-limiting on major compactions,
we noted that many of the changes were related to passing an extra argument (RateLimiter)
around through all of the code which is related to file interaction.
> It would be nice to move to a centralized configuration object instead of having to add
a new argument every time some new feature is added to the file-path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message