accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4195) Generalized configuration object for Accumulo rfile interaction
Date Mon, 25 Apr 2016 13:46:12 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256364#comment-15256364
] 

ASF GitHub Bot commented on ACCUMULO-4195:
------------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/95#discussion_r60914702
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/FileOperations.java ---
    @@ -48,38 +48,295 @@ public static FileOperations getInstance() {
         return new DispatchingFileFactory();
       }
     
    +  //
    +  // Abstract methods (to be implemented by subclasses)
    +  //
    +
    +  protected abstract long getFileSize(GetFileSizeOperation options) throws IOException;
    +
    +  protected abstract FileSKVWriter openWriter(OpenWriterOperation options) throws IOException;
    +
    +  protected abstract FileSKVIterator openIndex(OpenIndexOperation options) throws IOException;
    +
    +  protected abstract FileSKVIterator openScanReader(OpenScanReaderOperation options)
throws IOException;
    +
    +  protected abstract FileSKVIterator openReader(OpenReaderOperation options) throws IOException;
    +
    +  //
    +  // File operations
    +  //
    +
       /**
    -   * Open a reader that will not be seeked giving an initial seek location. This is useful
for file operations that only need to scan data within a range and do
    -   * not need to seek. Therefore file metadata such as indexes does not need to be kept
in memory while the file is scanned. Also seek optimizations like bloom
    -   * filters do not need to be loaded.
    +   * Construct an operation object allowing one to query the size of a file. <br>
    +   * Syntax:
        *
    +   * <pre>
    +   * long size = fileOperations.getFileSize().ofFile(filename, fileSystem, fsConfiguration).withTableConfiguration(tableConf).execute();
    --- End diff --
    
    Yeah, sometime the formatter is a bit aggressive. You can disable it for some portion
of code by
    
    ```
    /* @formatter:off */
    ... my pre-formatted stuff...
    /* @formatter:on */
    ```


> Generalized configuration object for Accumulo rfile interaction
> ---------------------------------------------------------------
>
>                 Key: ACCUMULO-4195
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4195
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Josh Elser
>            Assignee: Shawn Walker
>             Fix For: 1.8.0
>
>
> Taken from https://github.com/apache/accumulo/pull/90/files#r59489073
> On [~ShawnWalker]'s PR for ACCUMULO-4187 which adds rate-limiting on major compactions,
we noted that many of the changes were related to passing an extra argument (RateLimiter)
around through all of the code which is related to file interaction.
> It would be nice to move to a centralized configuration object instead of having to add
a new argument every time some new feature is added to the file-path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message