accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4191) Tracing on client can sometimes lose "sendMutations" events.
Date Sat, 16 Apr 2016 21:21:25 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244405#comment-15244405
] 

ASF GitHub Bot commented on ACCUMULO-4191:
------------------------------------------

Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/94#issuecomment-210903933
  
    >  I wonder if we worked around something in cloudtrace
    
    Yeeeeeep. In `NamingThreadFactory#newThread(Runnable)`.
    
    ```
    return new Daemon(new LoggingRunnable(log, new TraceRunnable(r)), name + " " + threadNum.getAndIncrement());
    ```
    
    I'll apply this to 1.7 and master. Thanks again for the detailed analysis, @ShawnWalker!
Great work.


> Tracing on client can sometimes lose "sendMutations" events.
> ------------------------------------------------------------
>
>                 Key: ACCUMULO-4191
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4191
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Shawn Walker
>            Assignee: Shawn Walker
>            Priority: Minor
>
> In {{TabletServerBatchWriter.MutationWriter.queueMutations(...)}} (line 736), HTrace
{{Span}}'s are not properly propagated across thread boundaries.  Consequently, tracing doesn't
propagate into {{TabletServerBatchWriter.SendTask.send(...)}}, and so the {{sendMutation}}
event can fail to be logged.
> This can cause {{ShellServerIT.trace(...)}} to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message