accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4191) Tracing on client can sometimes lose "sendMutations" events.
Date Fri, 15 Apr 2016 15:01:25 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243072#comment-15243072
] 

ASF GitHub Bot commented on ACCUMULO-4191:
------------------------------------------

Github user joshelser commented on the pull request:

    https://github.com/apache/accumulo/pull/94#issuecomment-210495111
  
    > This should allow proper tracing propagation across the binning thread pool, and
consequently prevent loss of "sendMutation" events.
    > In TabletServerBatchWriter.MutationWriter.queueMutations(...) (line 736), HTrace
Span's are not properly propagated across thread boundaries. Consequently, tracing doesn't
propagate into TabletServerBatchWriter.SendTask.send(...), and so the sendMutation event can
fail to be logged.
    
    So, IIRC, Tracer maintains the current Span via a ThreadLocal. So, I could see spawning
a new Thread in the binning process might lose that, and the "lower" half of the span would
be un-rooted (the part doing binning and sending).
    
    A couple of questions:
    * Any thoughts on how we could make a test which would specifically check for regressions
here?
    * Have you been able to notice your changes positively affecting `ShellServerIT#trace`'s
success rate? I have seen it fail now and again, but never reliably.
    * Any idea as to why we only *sometimes* see ShellServerIT fail? Is there a reason why
this doesn't always fail that you noticed?
    
    Thanks!



> Tracing on client can sometimes lose "sendMutations" events.
> ------------------------------------------------------------
>
>                 Key: ACCUMULO-4191
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4191
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Shawn Walker
>            Assignee: Shawn Walker
>            Priority: Minor
>
> In {{TabletServerBatchWriter.MutationWriter.queueMutations(...)}} (line 736), HTrace
{{Span}}'s are not properly propagated across thread boundaries.  Consequently, tracing doesn't
propagate into {{TabletServerBatchWriter.SendTask.send(...)}}, and so the {{sendMutation}}
event can fail to be logged.
> This can cause {{ShellServerIT.trace(...)}} to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message