accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4191) Tracing on client can sometimes lose "sendMutations" events.
Date Fri, 15 Apr 2016 14:49:25 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243056#comment-15243056
] 

ASF GitHub Bot commented on ACCUMULO-4191:
------------------------------------------

GitHub user ShawnWalker opened a pull request:

    https://github.com/apache/accumulo/pull/94

    ACCUMULO-4191 Tracing on client can sometimes lose "sendMutations" events.

    Wrapped a `Runnable` with `Trace.wrap(...)` in `TabletServerBatchWriter`.  This should
allow proper tracing propagation across the binning thread pool, and consequently prevent
loss of "sendMutation" events.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ShawnWalker/accumulo ACCUMULO-4191

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #94
    
----
commit 2407283e43613290225084737036b9ae8a76bc98
Author: Shawn Walker <accumulo@shawn-walker.net>
Date:   2016-04-15T14:38:37Z

    ACCUMULO-4191 Wrapped runnable with Trace.wrap in TabletServerBatchWriter to prevent loss
of sendMutation events

----


> Tracing on client can sometimes lose "sendMutations" events.
> ------------------------------------------------------------
>
>                 Key: ACCUMULO-4191
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4191
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Shawn Walker
>            Assignee: Shawn Walker
>            Priority: Minor
>
> In {{TabletServerBatchWriter.MutationWriter.queueMutations(...)}} (line 736), HTrace
{{Span}}'s are not properly propagated across thread boundaries.  Consequently, tracing doesn't
propagate into {{TabletServerBatchWriter.SendTask.send(...)}}, and so the {{sendMutation}}
event can fail to be logged.
> This can cause {{ShellServerIT.trace(...)}} to fail.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message