accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4187) Rate limiting of major compactions
Date Wed, 13 Apr 2016 04:16:25 GMT


ASF GitHub Bot commented on ACCUMULO-4187:

Github user joshelser commented on the pull request:
    Made a first pass through the code. Wow! Great work for a first contribution @ShawnWalker!
Some general themes:
    * nit-picky stylistic things
    * Missing javadoc on public classes/methods
    Some new tests on these new classes (testing the rate limiting components and input/output
streams should be really important) would really make this even better.
    I'll have to go back to reread about the use of `<T extends Class & Interface>`
littered everywhere with a fresh mind. First time I've run across it and I don't think I entirely
grokked the point.

> Rate limiting of major compactions
> ----------------------------------
>                 Key: ACCUMULO-4187
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: core, tserver
>    Affects Versions: 1.8.0
>            Reporter: Shawn Walker
>            Assignee: Shawn Walker
>            Priority: Minor
>             Fix For: 1.8.0
> In discussing [ACCUMULO-4166] with Keith Turner, we decided that the underlying issue
is that major compactions can overwhelm a tablet server, rendering it nearly unresponsive.
> To address this, we should take a cue from Apache Cassandra and restrict how quickly
we perform major compactions.  Rate limiting reads and writes involved in major compactions
will directly affect the IO load caused by major compactions, and should also indirectly affect
the CPU load.

This message was sent by Atlassian JIRA

View raw message