accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4178) include table ids in client writer threads
Date Mon, 04 Apr 2016 17:58:25 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224636#comment-15224636
] 

ASF GitHub Bot commented on ACCUMULO-4178:
------------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/87#discussion_r58418513
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/TabletServerBatchWriter.java
---
    @@ -831,11 +814,16 @@ public void send(TabletServerMutations<Mutation> tsm) throws
AccumuloServerExcep
             try {
     
               long count = 0;
    -          for (List<Mutation> list : mutationBatch.values()) {
    -            count += list.size();
    +
    +          Set<Text> tableIds = new TreeSet<Text>();
    +          for (Map.Entry<KeyExtent,List<Mutation>> entry : mutationBatch.entrySet())
{
    +            count += entry.getValue().size();
    +            tableIds.add(entry.getKey().getTableId());
               }
    -          String msg = "sending " + String.format("%,d", count) + " mutations to " +
String.format("%,d", mutationBatch.size()) + " tablets at " + location;
    -          Thread.currentThread().setName(msg);
    +          StringBuilder msg = new StringBuilder();
    --- End diff --
    
    If you're going to build up `msg` inside of the for loop, I think it makes sense to use
the StringBuilder. Just in the current state, it didn't look like there was any benefit to
the use of a StringBuilder (so it just came across as an unnecessary change).


> include table ids in client writer threads
> ------------------------------------------
>
>                 Key: ACCUMULO-4178
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4178
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>    Affects Versions: 1.6.5
>            Reporter: Ivan Bella
>            Priority: Minor
>             Fix For: 1.6.6
>
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> The client threads are renamed with a title denoting the number of mutations being sent,
the number of tablets being sent to and the tserver hostname.  It would be useful to include
the tables names or ids in this thread name when trying to diagnose issues related to hot
spotting within a system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message