Return-Path: 
 <notifications-return-34173-apmail-accumulo-notifications-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7E4A4189FC
	for <apmail-accumulo-notifications-archive@minotaur.apache.org>;
 Wed, 24 Feb 2016 22:51:18 +0000 (UTC)
Received: (qmail 13455 invoked by uid 500); 24 Feb 2016 22:51:18 -0000
Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org
Received: (qmail 13381 invoked by uid 500); 24 Feb 2016 22:51:18 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 13246 invoked by uid 99); 24 Feb 2016 22:51:18 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Feb 2016 22:51:18 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 14AF92C14F8
	for <notifications@accumulo.apache.org>;
 Wed, 24 Feb 2016 22:51:18 +0000 (UTC)
Date: Wed, 24 Feb 2016 22:51:18 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12943023.1456336859000.138632.1456354278081@Atlassian.JIRA>
In-Reply-To: <JIRA.12943023.1456336859000@Atlassian.JIRA>
References: <JIRA.12943023.1456336859000@Atlassian.JIRA>
 <JIRA.12943023.1456336859616@arcas>
Subject: [jira] [Commented] (ACCUMULO-4153) Change getCodec method in
 BCFile's Compression class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/ACCUMULO-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15165673#comment-15165673 ] 

ASF GitHub Bot commented on ACCUMULO-4153:
------------------------------------------

Github user madrob commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/73#discussion_r54021185
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java ---
    @@ -147,25 +148,27 @@ public synchronized OutputStream createCompressionStream(OutputStream downStream
         },
     
         GZ(COMPRESSION_GZ) {
    -      private transient DefaultCodec codec;
    +      private transient AtomicReference<DefaultCodec> codec = new AtomicReference<DefaultCodec>();
     
           @Override
    -      synchronized CompressionCodec getCodec() {
    -        if (codec == null) {
    -          codec = new DefaultCodec();
    -          codec.setConf(conf);
    +      CompressionCodec getCodec() {
    +        DefaultCodec resultCodec = codec.get();
    +        if (null == resultCodec) {
    +          DefaultCodec newCodec = new DefaultCodec();
    --- End diff --
    
    The merit of creating it at construction time depends on how costly the initialization is. I'm under the impression that it's not _that_ bad, so eager initialization is probably ok here and we don't have to worry about concurrency at all. Good point, @brianloss.


> Change getCodec method in BCFile's Compression class
> ----------------------------------------------------
>
>                 Key: ACCUMULO-4153
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4153
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.6.5
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Minor
>             Fix For: 1.6.6, 1.7.2, 1.8.0
>
>         Attachments: patchCompression
>
>
> Seeing major blockages blockages on the Synchronized method of getCodec.  My initial change was to change it to double checked locking; however, spoke with [~kturner] and I'm changing this to an AtomicReference. Have a patch for the former but am in the process of testing the AtomicReference patch
> Note this is for Gzip



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)