accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4153) Change getCodec method in BCFile's Compression class
Date Wed, 24 Feb 2016 21:22:18 GMT


ASF GitHub Bot commented on ACCUMULO-4153:

Github user joshelser commented on the pull request:
    I apparently clicked through to the commit and left a bunch of comments instead of commenting
on the PR itself. Sorry about that.
    Overall, this looks pretty good. Some nit-picky things on the test case (yay, tests!)
and a similar recommendation to Marc's earlier note.

> Change getCodec method in BCFile's Compression class
> ----------------------------------------------------
>                 Key: ACCUMULO-4153
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.6.5
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Minor
>             Fix For: 1.6.6, 1.7.2, 1.8.0
>         Attachments: patchCompression
> Seeing major blockages blockages on the Synchronized method of getCodec.  My initial
change was to change it to double checked locking; however, spoke with [~kturner] and I'm
changing this to an AtomicReference. Have a patch for the former but am in the process of
testing the AtomicReference patch
> Note this is for Gzip

This message was sent by Atlassian JIRA

View raw message