accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4153) Change getCodec method in BCFile's Compression class
Date Wed, 24 Feb 2016 21:08:18 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163808#comment-15163808
] 

ASF GitHub Bot commented on ACCUMULO-4153:
------------------------------------------

GitHub user phrocker opened a pull request:

    https://github.com/apache/accumulo/pull/73

    ACCUMULO-4153: Update the getCodec method to no longer be synchronize…

    …d and to use an atomic reference.
    
    This is based only on JSTACKs across a running system. I've seen improvement as a result
with local testing and will test at a larger scale as time permits. I can provide performance
numbers if needed for the PR. 
    
    I'm basing this against 1.6 as that is where we will test it and use it. It should merge
cleanly up to 1.7 and 1.8. 
    
    This is a very simple change. I added a unit test ( the last of which shows that we won't
run into the problem of creating many )...though if it fails for you let me know! 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phrocker/accumulo-1 ACCUMULO4153

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/73.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #73
    
----
commit 7c689dda9d626da18af7e0a706201b3f67a96643
Author: phrocker <marc.parisi@gmail.com>
Date:   2016-02-24T20:40:08Z

    ACCUMULO-4153: Update the getCodec method to no longer be synchronized and to use an atomic
reference.

----


> Change getCodec method in BCFile's Compression class
> ----------------------------------------------------
>
>                 Key: ACCUMULO-4153
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4153
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.6.5
>            Reporter: marco polo
>            Assignee: marco polo
>            Priority: Minor
>             Fix For: 1.6.6, 1.7.2, 1.8.0
>
>         Attachments: patchCompression
>
>
> Seeing major blockages blockages on the Synchronized method of getCodec.  My initial
change was to change it to double checked locking; however, spoke with [~kturner] and I'm
changing this to an AtomicReference. Have a patch for the former but am in the process of
testing the AtomicReference patch
> Note this is for Gzip



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message