accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4141) RFile metadata not loading from cache
Date Mon, 22 Feb 2016 22:09:18 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157807#comment-15157807
] 

Josh Elser commented on ACCUMULO-4141:
--------------------------------------

A bit late since this was already committed (but maybe we can clean up in a follow-on):

{code}
+import com.google.common.base.Charsets;
{code}

Rely on {{StandardCharsets}} instead (and do the old Charset.forName in 1.6)? I feel like
avoiding Guava seeping in will be better in the long-run.

{noformat}
 The patch doesn't appear to include any new or modified tests. Please justify why no new
tests are needed for this patch. Also please list what manual steps were performed to verify
this patch. 
{noformat}

While I don't mean to assert that HadoopQA is binding, I have no understanding about whether
or not your changes are actually doing what you say they are. Any opinions on how to better
test this going forward? You had mentioned in IRC about making a real API around RFile, would
things get implicitly easier to test with such an API?

> RFile metadata not loading from cache 
> --------------------------------------
>
>                 Key: ACCUMULO-4141
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4141
>             Project: Accumulo
>          Issue Type: Bug
>          Components: tserver
>    Affects Versions: 1.6.4, 1.7.0
>            Reporter: Keith Turner
>            Assignee: Keith Turner
>             Fix For: 1.6.6, 1.7.1, 1.8.0
>
>         Attachments: ACCUMULO-4141-1.6.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In [BCFile line 818|https://github.com/apache/accumulo/blob/1.6.4/core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java#L818]
an attempt to read crypto metadata from cache is made.  Then at [BCFile line 820|https://github.com/apache/accumulo/blob/1.6.4/core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java#L820]
if that crypto metadata does not exist, some BC file metadata is read from the file.  For
unencrypted files this data will never exist in cache.  Therefore for unencrypted files metadata
will always be read from the file, even when its cached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message