accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4138) CompactCommand description is incorrect
Date Thu, 18 Feb 2016 20:27:18 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153023#comment-15153023
] 

ASF GitHub Bot commented on ACCUMULO-4138:
------------------------------------------

GitHub user mjwall opened a pull request:

    https://github.com/apache/accumulo/pull/71

    ACCUMULO-4138 Fix the description of -b options

    It was wrong for FlushCommand and CompactCommand.  In the process of
    refactoring, the following was accomplished:
    
    - Change the description in the OptUtil.startRowOpt to be (NOT) inclusive.
    - Use OptUtil.startRowOpt in CompactCommand, MergeCommand and FlushCommand.
    - Refactor the DeleteRowCommand to use the OptUtil.startRowOpt method.
    - Refactor ScanCommand to override the description to say it is inclusive.
    
    Also updated the javadoc from a potential cut and paste on TableOperations.
    
    A little mixed on the usefulness of the Unit Tests for these.  They may be
    brittle, but perhaps they would alert if someone changed the way one command
    worked without looking at the others.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mjwall/accumulo 4138-compact-command

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/71.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #71
    
----
commit 50db442b04f615ce698d0f63545917be6d4fb13c
Author: Michael Wall <mjwall@gmail.com>
Date:   2016-02-18T20:22:09Z

    ACCUMULO-4138 Fix the description of -b options
    
    It was wrong for FlushCommand and CompactCommand.  In the process of
    refactoring, the following was accomplished:
    
    - Change the description in the OptUtil.startRowOpt to be (NOT) inclusive.
    - Use OptUtil.startRowOpt in CompactCommand, MergeCommand and FlushCommand.
    - Refactor the DeleteRowCommand to use the OptUtil.startRowOpt method.
    - Refactor ScanCommand to override the description to say it is inclusive.
    
    Also updated the javadoc from a potential cut and paste on TableOperations.
    
    A little mixed on the usefulness of the Unit Tests for these.  They may be
    brittle, but perhaps they would alert if someone changed the way one command
    worked without looking at the others.

----


> CompactCommand description is incorrect
> ---------------------------------------
>
>                 Key: ACCUMULO-4138
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4138
>             Project: Accumulo
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 1.6.4, 1.7.0
>            Reporter: Michael Wall
>            Assignee: Michael Wall
>              Labels: newbie
>             Fix For: 1.6.6, 1.7.2, 1.8.0
>
>
> The compact command has the following description 
> {code}
> root@accumulo> compact -?
> usage: compact [<table>{ <table>}] [-?] [-b <begin-row>] [--cancel]
[-e <end-row>] [-nf] [-ns <namespace> | -p <pattern> | -t <tableName>]
 [-pn <profile>]  [-w]
> description: sets all tablets for a table to major compact as soon as possible (based
on current time)
>   -?,--help                       display this help
>   -b,--begin-row <begin-row>      begin row (inclusive)
>      --cancel                     cancel user initiated compactions
>   -e,--end-row <end-row>          end row (inclusive)
>   -nf,--noFlush                   do not flush table data in memory before compacting.
>   -ns,--namespace <namespace>     name of a namespace to operate on
>   -p,--pattern <pattern>          regex pattern of table names to operate on
>   -pn,--profile <profile>         iterator profile name
>   -t,--table <tableName>          name of a table to operate on
>   -w,--wait                       wait for compact to finish
> {code}
> However, the --begin-row is not inclusive.  Here is a simple demonstration.
> {code}
> createtable compacttest
> addsplits a b c
> insert "a" "1" "" ""
> insert "a" "2" "" ""
> insert "b" "3" "" ""
> insert "b" "4" "" ""
> insert "c" "5" "" ""
> insert "c" "6" "" ""
> flush -w
> scan -t accumulo.metadata -np
> compact -b a -e c -t compacttest -w
> scan -t accumulo.metadata -np
> deletetable compacttest -f
> {code}
> You will see that file associated with the 'a' split is still a F flush file, which the
files in the 'b' and 'c' split are A files.
> Not sure if the fix is to update the commands description, which would be easy, or to
make the begin row actually inclusive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message