accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4132) TableOperations::listSplits returns Collection<Text> TableOperations::addSplits takes SortedSet<Text>
Date Wed, 03 Feb 2016 18:38:39 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130840#comment-15130840
] 

Keith Turner commented on ACCUMULO-4132:
----------------------------------------

It seems like your proposed change would be source compatible.   However I am uncertain if
its binary compatible.   Will code compiled against {{TableOperations::addSplits(SortedSet<Text>)}}
work with {{TableOperations::addSplits(Collection<Text>)}}?  I suspect its not binary
compat, but not positive.  We can only make the changes if its binary compat.  

If not binary compat, another possible option is to add a method {{TableOperations::addSplits(Collection<Text>)}}
and not remove {{TableOperations::addSplits(SortedSet<Text>)}}.  Should be able to have
both.

> TableOperations::listSplits returns Collection<Text> TableOperations::addSplits
takes SortedSet<Text>
> -----------------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-4132
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4132
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Wil Selwood
>            Priority: Minor
>
> When copying the splits from one table to another (we are re-encoding some of the data
on route) the TableOperations::listSplits method returns a Collection<Text> however
the TableOperations::addSplits method takes a SortedSet<Text>
> Apart from the fact it will change the API this looks like a relatively simple change.
If the API change is acceptable I should be able to provide a patch. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message