Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40AA2181CC for ; Sun, 24 Jan 2016 09:42:40 +0000 (UTC) Received: (qmail 93731 invoked by uid 500); 24 Jan 2016 09:42:40 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 93692 invoked by uid 500); 24 Jan 2016 09:42:40 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 93672 invoked by uid 99); 24 Jan 2016 09:42:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Jan 2016 09:42:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D5A5B2C1F58 for ; Sun, 24 Jan 2016 09:42:39 +0000 (UTC) Date: Sun, 24 Jan 2016 09:42:39 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-4115) Thrift generation always replaces files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15114254#comment-15114254 ] ASF GitHub Bot commented on ACCUMULO-4115: ------------------------------------------ GitHub user ctubbsii opened a pull request: https://github.com/apache/accumulo/pull/65 ACCUMULO-4115 Use undated annotations Uses undated annotations for thrift-generated java classes You can merge this pull request into a Git repository by running: $ git pull https://github.com/ctubbsii/accumulo ACCUMULO-4115 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/accumulo/pull/65.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #65 ---- commit ee7b24ab7ba227c0ff16d4684de87be77438d8c1 Author: Christopher Tubbs Date: 2016-01-24T09:34:40Z Use undated option for thrift java generation Use generated_annotations=undated to prevent changing generated files every time the build is run with the thrift profile active. commit d43685c9898bc4aa17689cebcbb9766c208dda87 Author: Christopher Tubbs Date: 2016-01-24T09:38:51Z Regenerate thrift without dated annotations ---- > Thrift generation always replaces files > --------------------------------------- > > Key: ACCUMULO-4115 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4115 > Project: Accumulo > Issue Type: Bug > Reporter: Christopher Tubbs > Fix For: 1.8.0 > > > Since the switch to thrift 0.9.3 in ACCUMULO-4077, all thrift-generated files get a {{"date = %Y-%m-%d"}} (I'm using `man date` syntax here) parameter to a {{@Generated}} annotation. This causes all checked-in files to be replaced whenever the {{-Pthrift}} profile is used. > This is going to cause problems for us when we run the release plugin, which activates this profile, and will cause the resulting builds to differ from checked-in code. It will also create a lot of noise in git when making small changes to thrift classes. > Rather than copy over all changed files when running with the thrift profile, we should only copy over files which differ by more than the date in this annotation. Alternatively, we can suppress the dates using the java option for thrift {{generated_annotations=undated}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)