accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4119) Consistently use DataFileValue to parse as UTF-8
Date Thu, 28 Jan 2016 00:19:39 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120486#comment-15120486
] 

Christopher Tubbs commented on ACCUMULO-4119:
---------------------------------------------

Dunno why it didn't catch this. Perhaps modernizer-maven-plugin would have?

I started on this, and found other places where we just lazily throw in a String literal instead
of using DataFileValue, too. Like, in some of our tests, we throw in "1,200" (that is to say,
a file of size {{1 byte}} containing {{200}} entries... very small entries, apparently). I'll
move all that I can find to the DataFileValue class, and ensure the UTF-8 occurs there. I'll
probably also add a test for the encoding, just because it'll set me up for testing ACCUMULO-4118
modifications.

> Consistently use DataFileValue to parse as UTF-8
> ------------------------------------------------
>
>                 Key: ACCUMULO-4119
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4119
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>             Fix For: 1.6.5, 1.7.1, 1.8.0
>
>
> Noticed that we weren't always using DataFileValue to parse file values from the metadata
tables, and also that DataFileValue doesn't specify UTF-8 encoding explicitly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message