accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-4115) Thrift generation always replaces files
Date Sun, 24 Jan 2016 14:39:39 GMT


Christopher Tubbs commented on ACCUMULO-4115:

Cool. I'll go ahead and merge this in then. We can always change it if somebody feels a compelling
need to have the date of the generation beyond the git logs, and in addition to the version
of Thrift (pretty sure thrift doesn't generate different code on different days...)

> Thrift generation always replaces files
> ---------------------------------------
>                 Key: ACCUMULO-4115
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>             Fix For: 1.8.0
> Since the switch to thrift 0.9.3 in ACCUMULO-4077, all thrift-generated files get a {{"date
= %Y-%m-%d"}} (I'm using `man date` syntax here) parameter to a {{@Generated}} annotation.
This causes all checked-in files to be replaced whenever the {{-Pthrift}} profile is used.
> This is going to cause problems for us when we run the release plugin, which activates
this profile, and will cause the resulting builds to differ from checked-in code. It will
also create a lot of noise in git when making small changes to thrift classes.
> Rather than copy over all changed files when running with the thrift profile, we should
only copy over files which differ by more than the date in this annotation. Alternatively,
we can suppress the dates using the java option for thrift {{generated_annotations=undated}}.

This message was sent by Atlassian JIRA

View raw message