accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4111) Float Lexicoder
Date Fri, 15 Jan 2016 19:12:39 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102320#comment-15102320
] 

Keith Turner commented on ACCUMULO-4111:
----------------------------------------

Thanks for the patch.   I will add you as a contributor in Jira and assign this issue to you.
 Two comment regarding the patch :

 * The class needs a {{@since 1.8.0}} javadoc tag
 * Would you be able to modify the patch to extend {{AbstractLexicoder}} and have a {{ protected
Float decodeUnchecked(byte[] data, int offset, int len)}}} method? This is to follow the precedent
set in ACCUMULO-3789.

> Float Lexicoder
> ---------------
>
>                 Key: ACCUMULO-4111
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4111
>             Project: Accumulo
>          Issue Type: Wish
>          Components: client
>    Affects Versions: 1.7.0
>            Reporter: Wil Selwood
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.8.0
>
>         Attachments: ACCUMULO-4111.patch
>
>
> There are Integer, Long, and BigInteger lexicoders. However there is only a Double lexicoder
for floating point numbers. 
> While we can just use the double one and take up some extra space this feels a little
wasteful and miss matched.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message