accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-4105) MiniAccumuloClusterConfigImpl doesn't implement MiniAccumuloClusterConfig
Date Sun, 10 Jan 2016 18:40:39 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091150#comment-15091150
] 

Josh Elser commented on ACCUMULO-4105:
--------------------------------------

Thanks for letting us know your pains, Jim.

Brief history: MiniAccumuloCluster and MiniAccumuloConfig were added to public API (since
they were intended for user-interaction). As we really started migrating all of our integration
tests (and writing new ones) using MiniAccumuloCluster, we found lots of little changes we
needed over and over again. When we went to make the next release, this obviously broke our
application of [semver|http://accumulo.apache.org/versioning.html]. As such, Keith made corresponding
MiniAccumuloClusterImpl and MIniAccumuloConfigImpl classes that work with each other, leaving
MiniAccumuloCluster and MiniAccumuloConfig working as they previously had (for the backwards
compat aspect of our versioning policy).

I know that we've had discussions about whether or not some new method added to MAClusterImpl
or MAConfigImpl should be exposed to the "public API", often time erring on the side of "people
probably don't need this". However, it sounds like you found one example which is useful to
you.

Where there other hidden methods that were useful for for you?

> MiniAccumuloClusterConfigImpl doesn't implement MiniAccumuloClusterConfig
> -------------------------------------------------------------------------
>
>                 Key: ACCUMULO-4105
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4105
>             Project: Accumulo
>          Issue Type: Bug
>          Components: mini
>    Affects Versions: 1.8.0
>            Reporter: Jim Klucar
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> I was launching MiniAccumuloCluster and needed to add a jar to the classpath. MiniAccumuloClusterConfigImpl
has a method setClasspathItems(String ...) that I used for this purpose. Unfortunately since
MiniAccumuloClusterConfigImpl doesn't declare that it implements MiniAccumuloClusterConfig,
I had to use MiniAccumuloClusterImpl instead of MiniAccumuloCluster. Not sure what the right
solution is here. At the end of the day, explicitly adding things to the classpath is the
feature I needed. It was there, but not in the public API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message