accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Dailey (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-2493) BinaryFormatter needs to be refactored
Date Mon, 04 Jan 2016 05:14:40 GMT


Matt Dailey commented on ACCUMULO-2493:

I liked the Supplier interface idea, so I refactored the class to be called {{DateFormatSupplier
extends ... implements Supplier<DateFormat>}}.

The FormatterEnv change I was on the fence about, and ended up not including it in my pull
request.  I like the idea of extra power for the Formatter via context, but adding a dependency
to a Connector ties Formatters to only be used in that context.  Formatters wouldn't be usable
to just format entries, like in a MapReduce context where there is no active Connector.

> BinaryFormatter needs to be refactored
> --------------------------------------
>                 Key: ACCUMULO-2493
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: Mike Drob
>            Assignee: Matt Dailey
>              Labels: newbie
>             Fix For: 1.7.1, 1.8.0
> BinaryFormatter is currently used in a couple places in the shell, but the code is hard
to read and understand. There is a static getlength, which is actually a setter, and all the
instance calls end up going through unnecessary static methods.
> This combination makes it hard to reuse BinaryFormatter objects, or even use multiple,
since the static state is likely to conflict.

This message was sent by Atlassian JIRA

View raw message