accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2493) BinaryFormatter needs to be refactored
Date Mon, 04 Jan 2016 05:06:39 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080703#comment-15080703
] 

ASF GitHub Bot commented on ACCUMULO-2493:
------------------------------------------

GitHub user matthew-dailey opened a pull request:

    https://github.com/apache/accumulo/pull/61

    ACCUMULO-2493: Deprecated BinaryFormatter in favor of DefaultFormatter

    with FormatterConfig.
    
    * New class FormatterConfig handles configuration of Formatter objects
    * FormatterConfig is taken by Formatter.initialize, which broke the
    interface for many classes throughout the non-public API
    * Added DateFormatSupplier to let Formatters use DateFormat in a
    Thread-safe way
    * Removed code from ScanCommand and Shell tied to BinaryFormatter to use
    properly configured DefaultFormatter instead
    * Fixed bug where `scan -f [num] -fm [class]` would ignore Formatter
    class used in `-fm` and be overridden with BinaryFormatter

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matthew-dailey/accumulo ACCUMULO-2493-1.7-squashed

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/61.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #61
    
----
commit 8f60b4b1cb87f6bc315479d240e9e17b212a16a9
Author: Matt Dailey <matthew.dailey1@gmail.com>
Date:   2015-12-05T02:50:58Z

    ACCUMULO-2493: Deprecated BinaryFormatter in favor of DefaultFormatter
    with FormatterConfig.
    
    * New class FormatterConfig handles configuration of Formatter objects
    * FormatterConfig is taken by Formatter.initialize, which broke the
    interface for many classes throughout the non-public API
    * Added DateFormatSupplier to let Formatters use DateFormat in a
    Thread-safe way
    * Removed code from ScanCommand and Shell tied to BinaryFormatter to use
    properly configured DefaultFormatter instead
    * Fixed bug where `scan -f [num] -fm [class]` would ignore Formatter
    class used in `-fm` and be overridden with BinaryFormatter

----


> BinaryFormatter needs to be refactored
> --------------------------------------
>
>                 Key: ACCUMULO-2493
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2493
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: Mike Drob
>            Assignee: Matt Dailey
>              Labels: newbie
>             Fix For: 1.7.1, 1.8.0
>
>
> BinaryFormatter is currently used in a couple places in the shell, but the code is hard
to read and understand. There is a static getlength, which is actually a setter, and all the
instance calls end up going through unnecessary static methods.
> This combination makes it hard to reuse BinaryFormatter objects, or even use multiple,
since the static state is likely to conflict.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message