accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher Tubbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-2493) BinaryFormatter needs to be refactored
Date Wed, 13 Jan 2016 19:50:39 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096874#comment-15096874
] 

Christopher Tubbs commented on ACCUMULO-2493:
---------------------------------------------

In the spirit of semver, it might be better to drop the 1.7 fixVersion for this, if it doesn't
clearly address a bug that affects 1.7 users or help with future 1.7 bug fixes. If it's just
trying to make the internals better, to ease future development, then it's probably better
targeted to 1.8/master.

However, I haven't looked closely enough at this issue to know which is the case. It does
seem that there's a risk it will change the behavior of the shell a bit for 1.7 users, but
perhaps the bugs it addresses make that risk acceptable? I'll defer to others. It was just
a point I thought might be worth raising.

> BinaryFormatter needs to be refactored
> --------------------------------------
>
>                 Key: ACCUMULO-2493
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2493
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: Mike Drob
>            Assignee: Matt Dailey
>              Labels: newbie
>             Fix For: 1.7.1, 1.8.0
>
>
> BinaryFormatter is currently used in a couple places in the shell, but the code is hard
to read and understand. There is a static getlength, which is actually a setter, and all the
instance calls end up going through unnecessary static methods.
> This combination makes it hard to reuse BinaryFormatter objects, or even use multiple,
since the static state is likely to conflict.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message