Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D520D18FFE for ; Thu, 3 Dec 2015 03:03:11 +0000 (UTC) Received: (qmail 71534 invoked by uid 500); 3 Dec 2015 03:03:11 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 71489 invoked by uid 500); 3 Dec 2015 03:03:11 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 71459 invoked by uid 99); 3 Dec 2015 03:03:11 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Dec 2015 03:03:11 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2A44B2C1F70 for ; Thu, 3 Dec 2015 03:03:11 +0000 (UTC) Date: Thu, 3 Dec 2015 03:03:11 +0000 (UTC) From: "Matt Dailey (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-2493) BinaryFormatter needs to be refactored MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15037158#comment-15037158 ] Matt Dailey commented on ACCUMULO-2493: --------------------------------------- Since adding an {{int maxLength}} option to {{Formatter.initialize}} would cause this issue to be brought up again whenever someone wants another configuration option down the road, I was thinking of changing {{Formatter.intialize}} to accept a hadoop {{Configuration}} object and let Formatters configure themselves. I like {{Configuration}} because of the helper getters and setters it has, but is that too heavyweight a solution for configuring a Formatter? The {{core}} package already brings in {{hadoop-client}}, so there's no additional dependency there. > BinaryFormatter needs to be refactored > -------------------------------------- > > Key: ACCUMULO-2493 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2493 > Project: Accumulo > Issue Type: Bug > Components: client > Reporter: Mike Drob > Assignee: Matt Dailey > Labels: newbie > Fix For: 1.7.1, 1.8.0 > > > BinaryFormatter is currently used in a couple places in the shell, but the code is hard to read and understand. There is a static getlength, which is actually a setter, and all the instance calls end up going through unnecessary static methods. > This combination makes it hard to reuse BinaryFormatter objects, or even use multiple, since the static state is likely to conflict. -- This message was sent by Atlassian JIRA (v6.3.4#6332)