Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Thu, 10 Dec 2015 17:14:11 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12559679.1339070749000.327340.1449767651000@Atlassian.JIRA>
In-Reply-To: <JIRA.12559679.1339070749000@Atlassian.JIRA>
References: <JIRA.12559679.1339070749000@Atlassian.JIRA>
 <JIRA.12559679.1339070749578@arcas>
Subject: [jira] [Commented] (ACCUMULO-626) create an iterator fuzz tester
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15051266#comment-15051266 ] 

ASF GitHub Bot commented on ACCUMULO-626:
-----------------------------------------

Github user dhutchis commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/50#discussion_r47254752
  
    --- Diff: iterator-test-harness/src/main/java/org/apache/accumulo/iteratortest/testcases/DeepCopyTestCase.java ---
    @@ -0,0 +1,63 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to you under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.iteratortest.testcases;
    +
    +import java.io.IOException;
    +import java.util.Collections;
    +import java.util.TreeMap;
    +
    +import org.apache.accumulo.core.data.ByteSequence;
    +import org.apache.accumulo.core.data.Key;
    +import org.apache.accumulo.core.data.Value;
    +import org.apache.accumulo.core.iterators.SortedKeyValueIterator;
    +import org.apache.accumulo.iteratortest.IteratorTestInput;
    +import org.apache.accumulo.iteratortest.IteratorTestOutput;
    +import org.apache.accumulo.iteratortest.IteratorTestUtil;
    +import org.apache.accumulo.iteratortest.environments.SimpleIteratorEnvironment;
    +
    +/**
    + * Test case that verifies that an iterator can use the generated instance from {@code deepCopy}.
    + */
    +public class DeepCopyTestCase extends OutputVerifyingTestCase {
    +
    +  @Override
    +  public IteratorTestOutput test(IteratorTestInput testInput) {
    +    final SortedKeyValueIterator<Key,Value> skvi = IteratorTestUtil.instantiateIterator(testInput);
    +    final SortedKeyValueIterator<Key,Value> source = IteratorTestUtil.createSource(testInput);
    +
    +    try {
    +      skvi.init(source, testInput.getIteratorOptions(), new SimpleIteratorEnvironment());
    +
    +      SortedKeyValueIterator<Key,Value> copy = skvi.deepCopy(new SimpleIteratorEnvironment());
    --- End diff --
    
    Some thoughts on another test-- call deepCopy in the middle of an iteration, in addition to the beginning after init() but before any next() calls.  Some iterators may do this in order to "save" the iteration at a certain point.


> create an iterator fuzz tester
> ------------------------------
>
>                 Key: ACCUMULO-626
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-626
>             Project: Accumulo
>          Issue Type: New Feature
>          Components: test
>            Reporter: Eric Newton
>            Assignee: Josh Elser
>
> Users often write iterators without fully understanding its limits and lifetime. Accumulo should have an iterator fuzz-tester which will take user data and run the iterator under extreme conditions.  For example, it should re-create and re-seek the iterator with every key returned.  It could automatically compare results of such a run with the naive run, which seeks to the beginning and scans all the data.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)