accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Dailey (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-2493) BinaryFormatter needs to be refactored
Date Thu, 03 Dec 2015 03:03:11 GMT


Matt Dailey commented on ACCUMULO-2493:

Since adding an {{int maxLength}} option to {{Formatter.initialize}} would cause this issue
to be brought up again whenever someone wants another configuration option down the road,
I was thinking of changing {{Formatter.intialize}} to accept a hadoop {{Configuration}} object
and let Formatters configure themselves.

I like {{Configuration}} because of the helper getters and setters it has, but is that too
heavyweight a solution for configuring a Formatter?  The {{core}} package already brings in
{{hadoop-client}}, so there's no additional dependency there.

> BinaryFormatter needs to be refactored
> --------------------------------------
>                 Key: ACCUMULO-2493
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: Mike Drob
>            Assignee: Matt Dailey
>              Labels: newbie
>             Fix For: 1.7.1, 1.8.0
> BinaryFormatter is currently used in a couple places in the shell, but the code is hard
to read and understand. There is a static getlength, which is actually a setter, and all the
instance calls end up going through unnecessary static methods.
> This combination makes it hard to reuse BinaryFormatter objects, or even use multiple,
since the static state is likely to conflict.

This message was sent by Atlassian JIRA

View raw message