Return-Path: 
 <notifications-return-32960-apmail-accumulo-notifications-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 7AD611882E
	for <apmail-accumulo-notifications-archive@minotaur.apache.org>;
 Tue, 17 Nov 2015 21:22:11 +0000 (UTC)
Received: (qmail 71056 invoked by uid 500); 17 Nov 2015 21:22:11 -0000
Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org
Received: (qmail 70990 invoked by uid 500); 17 Nov 2015 21:22:11 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 70958 invoked by uid 99); 17 Nov 2015 21:22:11 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 21:22:11 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 2A2742C1F5E
	for <notifications@accumulo.apache.org>;
 Tue, 17 Nov 2015 21:22:11 +0000 (UTC)
Date: Tue, 17 Nov 2015 21:22:11 +0000 (UTC)
From: "Josh Elser (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12913874.1447795284000.97452.1447795331169@Atlassian.JIRA>
In-Reply-To: <JIRA.12913874.1447795284000@Atlassian.JIRA>
References: <JIRA.12913874.1447795284000@Atlassian.JIRA>
 <JIRA.12913874.1447795284304@arcas>
Subject: [jira] [Created] (ACCUMULO-4057) Duplicated code in IteratorUtil
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394

Josh Elser created ACCUMULO-4057:
------------------------------------

             Summary: Duplicated code in IteratorUtil
                 Key: ACCUMULO-4057
                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4057
             Project: Accumulo
          Issue Type: Improvement
            Reporter: Josh Elser
            Priority: Trivial


Duplicated code in https://github.com/apache/accumulo/blob/master/core/src/main/java/org/apache/accumulo/core/iterators/IteratorUtil.java#L236

{code}
  public static <K extends WritableComparable<?>,V extends Writable> SortedKeyValueIterator<K,V> loadIterators(IteratorScope scope,
      SortedKeyValueIterator<K,V> source, KeyExtent extent, AccumuloConfiguration conf, List<IterInfo> ssiList, Map<String,Map<String,String>> ssio,
      IteratorEnvironment env, boolean useAccumuloClassLoader) throws IOException {
    List<IterInfo> iters = new ArrayList<IterInfo>(ssiList);
    Map<String,Map<String,String>> allOptions = new HashMap<String,Map<String,String>>();
    parseIteratorConfiguration(scope, iters, ssio, allOptions, conf);
    return loadIterators(source, iters, allOptions, env, useAccumuloClassLoader, conf.get(Property.TABLE_CLASSPATH));
  }

  public static <K extends WritableComparable<?>,V extends Writable> SortedKeyValueIterator<K,V> loadIterators(IteratorScope scope,
      SortedKeyValueIterator<K,V> source, KeyExtent extent, AccumuloConfiguration conf, List<IterInfo> ssiList, Map<String,Map<String,String>> ssio,
      IteratorEnvironment env, boolean useAccumuloClassLoader, String classLoaderContext) throws IOException {
    List<IterInfo> iters = new ArrayList<IterInfo>(ssiList);
    Map<String,Map<String,String>> allOptions = new HashMap<String,Map<String,String>>();
    parseIteratorConfiguration(scope, iters, ssio, allOptions, conf);
    return loadIterators(source, iters, allOptions, env, useAccumuloClassLoader, classLoaderContext);
  }
{code}

I thought I had commented on https://github.com/apache/accumulo/pull/51 about this, but maybe I forgot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)