accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3948) Enable A/B testing of scan iterators on a table
Date Wed, 11 Nov 2015 18:06:11 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000809#comment-15000809
] 

ASF GitHub Bot commented on ACCUMULO-3948:
------------------------------------------

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/51#discussion_r44564137
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/IteratorUtil.java ---
    @@ -235,10 +231,26 @@ public static String findIterator(IteratorScope scope, String className,
Accumul
             options.putAll(entry.getValue());
           }
         }
    +  }
     
    +  public static <K extends WritableComparable<?>,V extends Writable> SortedKeyValueIterator<K,V>
loadIterators(IteratorScope scope,
    +      SortedKeyValueIterator<K,V> source, KeyExtent extent, AccumuloConfiguration
conf, List<IterInfo> ssiList, Map<String,Map<String,String>> ssio,
    +      IteratorEnvironment env, boolean useAccumuloClassLoader) throws IOException {
    +    List<IterInfo> iters = new ArrayList<IterInfo>(ssiList);
    +    Map<String,Map<String,String>> allOptions = new HashMap<String,Map<String,String>>();
    +    parseIteratorConfiguration(scope, iters, ssio, allOptions, conf);
         return loadIterators(source, iters, allOptions, env, useAccumuloClassLoader, conf.get(Property.TABLE_CLASSPATH));
       }
     
    +  public static <K extends WritableComparable<?>,V extends Writable> SortedKeyValueIterator<K,V>
loadIterators(IteratorScope scope,
    +      SortedKeyValueIterator<K,V> source, KeyExtent extent, AccumuloConfiguration
conf, List<IterInfo> ssiList, Map<String,Map<String,String>> ssio,
    +      IteratorEnvironment env, boolean useAccumuloClassLoader, String context) throws
IOException {
    +    List<IterInfo> iters = new ArrayList<IterInfo>(ssiList);
    --- End diff --
    
    seems duplicative to the method with the same name above.


> Enable A/B testing of scan iterators on a table
> -----------------------------------------------
>
>                 Key: ACCUMULO-3948
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3948
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: tserver
>            Reporter: Dave Marion
>            Assignee: Dave Marion
>             Fix For: 1.8.0
>
>         Attachments: ACCUMULO-3948.1-6-3.patch, TestIterator.patch
>
>
> Classpath contexts are assigned to a table via the table configuration. You can test
at scale by cloning your table and assigning a new classpath context to the cloned table.
However, you would also need to change your application to use the new table names and since
we cannot disable compactions you would start to consume more space in the filesystem for
that table. We can support users passing in a context name to use for the scan on existing
tables. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message