accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3294) Need mechanism to update iterator settings
Date Sat, 14 Nov 2015 23:08:10 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15005659#comment-15005659
] 

Josh Elser commented on ACCUMULO-3294:
--------------------------------------

Thanks for the patch, [~parkjsung]. Some comments..

* Javadoc on the {{updateIterator}} method benefit from explicitly stating that this method
is only intended for use when the iterator is already configured at the given scope. Otherwise,
this javadoc is very nice.
* {{TableIteratorConfigHelper.java}} needs some Javadoc. Class level (why does it exists?
what's its purpose) and methods (what does the method do, what are the arguments required).
* Does {{TableIteratorConfigHelper#transformOptions}} need to use a TreeMap? Is keeping these
properties in sorted order important? If not, a HashMap would be better. Also relevant for
{{TableOperationsHelper.java}}.
* Would be nice to make sure the arguments to the constructor for {{TableIteratorConfigHelper}}
are non-null. {{java.util.Objects#requireNonNull(Object)}} is nice for this.
* Some basic comments on what each test is verifying in MockTableOperationsTest.java  would
be nice.
* An integration test would also be appreciated that verifies this API in practice. e.g. set
an iterator on a table, verify some query result, use this new API to change some configuration
on the iterator and observe that the query results changed. 

> Need mechanism to update iterator settings
> ------------------------------------------
>
>                 Key: ACCUMULO-3294
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3294
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: client
>            Reporter: John Vines
>            Assignee: Jonathan Park
>             Fix For: 1.8.0
>
>         Attachments: bug3294.patch, bug3294.patch.1
>
>
> Currently our API supports attachIterator, removeIterator, and getIteratorSettings. There
is no mechanism to directly change an iterators settings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message