Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C4C3109C3 for ; Sat, 24 Oct 2015 21:42:28 +0000 (UTC) Received: (qmail 33443 invoked by uid 500); 24 Oct 2015 21:42:28 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 33408 invoked by uid 500); 24 Oct 2015 21:42:28 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 33397 invoked by uid 99); 24 Oct 2015 21:42:28 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Oct 2015 21:42:28 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CEC722C1F5F for ; Sat, 24 Oct 2015 21:42:27 +0000 (UTC) Date: Sat, 24 Oct 2015 21:42:27 +0000 (UTC) From: "Josh Elser (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (ACCUMULO-4037) avoid a key copy in TimeSettingIterator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser reassigned ACCUMULO-4037: ------------------------------------ Assignee: Josh Elser > avoid a key copy in TimeSettingIterator > --------------------------------------- > > Key: ACCUMULO-4037 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4037 > Project: Accumulo > Issue Type: Improvement > Components: core > Affects Versions: 1.7.0 > Reporter: Adam Fuchs > Assignee: Josh Elser > Priority: Minor > Labels: performance > > In org.apache.accumulo.core.iterators.system.TimeSettingIterator we make a copy of the key before setting the time. Seems like this is a completely superfluous copy, and we should avoid it. In the current code we do the following: > {code} > @Override > public Key getTopKey() { > Key key = new Key(source.getTopKey()); > key.setTimestamp(time); > return key; > } > {code} > Instead we should do this: > {code} > @Override > public Key getTopKey() { > Key key = source.getTopKey(); > key.setTimestamp(time); > return key; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)