Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 19E4318A01 for ; Fri, 9 Oct 2015 15:25:27 +0000 (UTC) Received: (qmail 48870 invoked by uid 500); 9 Oct 2015 15:25:27 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 48831 invoked by uid 500); 9 Oct 2015 15:25:27 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 48815 invoked by uid 99); 9 Oct 2015 15:25:26 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Oct 2015 15:25:26 +0000 Date: Fri, 9 Oct 2015 15:25:26 +0000 (UTC) From: "Christopher Tubbs (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-3902) Ensure [Batch]Scanners are closed in ITs MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-3902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950555#comment-14950555 ] Christopher Tubbs commented on ACCUMULO-3902: --------------------------------------------- If we make them AutoCloseable, it should be easier to identify (and encourage closing) through compiler warnings. > Ensure [Batch]Scanners are closed in ITs > ---------------------------------------- > > Key: ACCUMULO-3902 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3902 > Project: Accumulo > Issue Type: Bug > Components: test > Reporter: Josh Elser > Priority: Trivial > Labels: newbie > Fix For: 1.7.2, 1.8.0 > > > Do an audit of the integration tests to verify that we actually close Scanners and BatchScanners. This is a best practice that we should be encouraging (by doing it in our tests). It can also lead to bugs in other test cases (ACCUMULO-3888). -- This message was sent by Atlassian JIRA (v6.3.4#6332)