accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (ACCUMULO-4037) avoid a key copy in TimeSettingIterator
Date Sun, 25 Oct 2015 01:16:27 GMT

     [ https://issues.apache.org/jira/browse/ACCUMULO-4037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Josh Elser resolved ACCUMULO-4037.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.8.0
                   1.7.1

> avoid a key copy in TimeSettingIterator
> ---------------------------------------
>
>                 Key: ACCUMULO-4037
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-4037
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.7.0
>            Reporter: Adam Fuchs
>            Assignee: Josh Elser
>            Priority: Minor
>              Labels: performance
>             Fix For: 1.7.1, 1.8.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In org.apache.accumulo.core.iterators.system.TimeSettingIterator we make a copy of the
key before setting the time. Seems like this is a completely superfluous copy, and we should
avoid it. In the current code we do the following:
> {code}
>   @Override
>   public Key getTopKey() {
>     Key key = new Key(source.getTopKey());
>     key.setTimestamp(time);
>     return key;
>   }
> {code}
> Instead we should do this:
> {code}
>   @Override
>   public Key getTopKey() {
>     Key key = source.getTopKey();
>     key.setTimestamp(time);
>     return key;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message