accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3988) License / notice errors
Date Thu, 10 Sep 2015 16:23:47 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739050#comment-14739050
] 

Sean Busbey commented on ACCUMULO-3988:
---------------------------------------

{quote}
bq. Hadoop (see note in Value.java. Hadoop's NOTICE file isn't properly formed, so could skip)
Perhaps I'm interpreting it differently than you, but the comment in Value reads to me that
the "style" of the class is based on Hadoop's BytesWritable, not that the code was directly
copied.
{quote}

That would be great. Normally I'd use blame and then email the author to confirm, but got
behind on this RC.

{quote}
bq. problems with missing references still exist
"bin" meaning "binary tarball"? And "still exist" referring to the items you referenced for
the "source tarball"?
{quote}

yeah, sorry, those are both correct interpretations.

{quote}
bq. missing Thrift entry in NOTICE file expands from one file to java libthrift
I don't understand what "expands from one file to java libthrift" means.
{quote}

I just meant that anything from thrift's LICENSE or NOTICE that we'd have to roll up into
our own files would be scoped to whatever is in libthrift.jar instead of just the one class.
I wrote this part before I had a chance to review the relevant LICENSE and NOTICE file. Looking
at them now, I think none of the call outs in Thrift's LICENSE apply to the java library so
the only difference would be if in our NOTICE file we specify what in particular we've included.

{quote}
bq. It's a modification based on ASLv2 code. I thought code that is already ASLv2 doesn't
require anything addt'l in the NOTICE
n/m Billie corrected me and point me to the right docs.
{quote}

For those reading along, this would be correct if they didn't have a NOTICE file (for an example,
check out excanvas.js. it's an add-on from a Google project called Explorer Canvas, which
is also ASLv2 but has no NOTICE file).

{quote}
Also, forgot to say a thanks for the diligence (with a sigh under my breath).
{quote}

no worries, license compliance has been my thing since [~joewitt] started nettling me about
it. I'm pretty used to being the bearer of bad news. :)

> License / notice errors
> -----------------------
>
>                 Key: ACCUMULO-3988
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3988
>             Project: Accumulo
>          Issue Type: Bug
>          Components: build
>            Reporter: Sean Busbey
>            Assignee: Josh Elser
>            Priority: Blocker
>             Fix For: 1.5.4
>
>
> latest 1.5.4 RC contains licensing errors. these might also be present in newer versions.
> * test/src/test/java/org/apache/accumulo/test/DeleteRowsTest.java has a botched license
header
> source tarball
> * LICENSE refs bundled works that are not present: jline
> * LICENSE incorrectly cites bundled work: jquery and flot (no copyright, no text of license),
bloom filters (no copyright, no text of license)
> * LICENSE misses some bundled works: 
> ** sizzle.js (see jquery.js file header)
> * NOTICE refs bundled works that are not present: jcommander
> * NOTICE misses some bundled works:
> ** Hadoop (see note in Value.java. Hadoop's NOTICE file isn't properly formed, so could
skip)
> ** Thrift (see note in TNonblockingServerSocket. Thrift 0.9 has a NOTICE file.)
> bin
> * problems with missing references still exist
> * missing Thrift entry in NOTICE file expands from one file to java libthrift
> * nit: JCommander should say that it's ASLv2 licensed
> * LICENSE and NOTICE files not updated for commons-math inclusion
> * NOTICE file not updated for commons-vfs2 inclusion
> * LICENSE and NOTICE files not updated for jetty inclusion
> accumulo-server jar / source-jar
> * missing LICENSE reference for jquery/flot/sizle
> * missing NOTICE for hadoop inclusion (but see not above about maybe skipping)
> * missing NOTICE for thrift class inclusion
> accumulo-core jar / source-jar
> * missing LICENSE reference for bloom filters	
> all jars
> * nit: jars contain NOTICE file that doesn't state the full name of the aggregate work
(e.g. "Core" rather than "Apache Accumulo Core" or some such)
> * jars contain NOTICE file that incorrectly states the aggregate work is copyright the
Accumulo project instead of the ASF



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message