accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-3913) Add per table sampling
Date Tue, 15 Sep 2015 02:55:45 GMT


ASF GitHub Bot commented on ACCUMULO-3913:

Github user joshelser commented on a diff in the pull request:
    --- Diff: core/src/test/java/org/apache/accumulo/core/iterators/
    @@ -18,17 +18,16 @@
    +import org.apache.accumulo.core.client.impl.TestIteratorEnvironment;
     import org.apache.accumulo.core.conf.AccumuloConfiguration;
    -import org.apache.accumulo.core.iterators.IteratorUtil.IteratorScope;
     import org.apache.accumulo.core.iterators.system.MapFileIterator;
     import org.apache.accumulo.core.util.CachedConfiguration;
     import org.apache.hadoop.conf.Configuration;
     import org.apache.hadoop.fs.FileSystem;
    -public class DefaultIteratorEnvironment implements IteratorEnvironment {
    +public class DefaultIteratorEnvironment extends TestIteratorEnvironment {
    --- End diff --
    This seems like a peculiar change to make. The DefaultIE extends one for tests?

> Add per table sampling
> ----------------------
>                 Key: ACCUMULO-3913
>                 URL:
>             Project: Accumulo
>          Issue Type: Improvement
>            Reporter: Keith Turner
>             Fix For: 1.8.0
> I am working on prototyping adding hash based sampling to Accumulo.  I am trying to accomplish
the following goals in the prototype.
>   # Have each RFile store a sample per locality group.  Also store the configuration
used to generate the sample.
>   # Use sampling functions that ensure the same row columns exist across the samples
in all RFiles. Hash mod is a good candidate that gives a random sample that's consistent across
>   # Have scanners support scanning RFile's samples sets.  Scan should fail if RFiles
have different sample configuration.  Different sampling config implies the RFile's sample
sets contain a possibly disjoint set of row columns.
>   # Support generating sample data for RFiles generated for bulk import
>   # Support sample data in the memory map
>   # Support enabling and disabling sampling per table AND configuring a sample function.
> I am currently using the following function in my prototype to determine what data an
RFile stores in its sample set.  This code will always select same subset of rows for each
RFile's sample set.  I have not yet made the function configurable.
> {code:java}
> public class RowSampler implements Sampler {
>   private HashFunction hasher = Hashing.murmur3_32();
>   @Override
>   public boolean accept(Key k) {
>     ByteSequence row = k.getRowData();
>     HashCode hc = hasher.hashBytes(row.getBackingArray(), row.offset(), row.length());
>     return hc.asInt() % 1009 == 0;
>   }
> }
> {code}
> Although not yet implemented, the divisor in this RowSample could be configurable. RFiles
with sample data would store the fact that a RowSample with a divisor of 1009 was used to
generate sample data.

This message was sent by Atlassian JIRA

View raw message