accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3946) Not all accumulo events are audited for Audit logging
Date Mon, 10 Aug 2015 20:02:45 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14680678#comment-14680678
] 

Josh Elser commented on ACCUMULO-3946:
--------------------------------------

Oh, I see that the create table op already was checking the boolean. I had assumed you changed
that in your last snippet since I knew other areas in the code do it differently. The general
recommendation is to not try to rework code-flow when you're just fixing a bug -- shoot for
the minimum number of changes. Your brain is likely a better judge than explicit recommendations
I can give about the code in general. But, for completeness, the {{canCreateTable}} call might
already throw a ThriftSecurityException so I'm not sure why it would necessitate a large change.

I would have thought this would be a simple patch where you just add the missing methods in
AuditedSecurityOperation like

{code}
@Override
public boolean canCreateTable(..) throws ThriftSecurityException {
  try {
    boolean result = super.canCreateTable(...);
    audit(SUCCESS);
    return result;
  } catch (ThriftSecurityException e) {
    audit(FAILURE);
    throw e;
  }
}
{code}

Am I missing  something that makes this more difficult?

> Not all accumulo events are audited for Audit logging
> -----------------------------------------------------
>
>                 Key: ACCUMULO-3946
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3946
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.5.3
>            Reporter: James Mello
>            Assignee: James Mello
>             Fix For: 1.5.4
>
>
> Currently accumulo does not log all the major events such as table creation and permissions
changes. Please modify the existing logging to include missing auditing. Note this is related
to ticket ACCUMUO-3939.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message