accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3840) Refactor OpTimer so that it does not use log4j logger.
Date Sun, 05 Jul 2015 11:47:04 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614223#comment-14614223
] 

ASF GitHub Bot commented on ACCUMULO-3840:
------------------------------------------

GitHub user EdColeman opened a pull request:

    https://github.com/apache/accumulo/pull/39

    ACCUMULO-3840 deprecated OpTimer and replaced usages with EventTimer …

    Added EventTimer class (based on hadoop 2.7 org.apache.hadoop.util.StopWatch) to remove
direct log4j dependencies inherent in OpTimer. Added scale method to provide conversion without
truncation that is not in StopWatch.
    
    These changes include suggestions from Josh and have been looked at a few times.
    
    This is being done as part of the log4j dependency removal and contains modification to
some log statements to remove string concatenation.
    
    Also available on review board at https://reviews.apache.org/r/36186/


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/EdColeman/accumulo ACCUMULO-3840

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
    
----
commit d9a8dfa2c318a56cff99a960bcd9eb6d5063445f
Author: Ed Coleman <dev1@etcoleman.com>
Date:   2015-05-22T14:02:35Z

    ACCUMULO-3840 deprecated OpTimer and replaced usages with EventTimer (based on hadoop
2.7 org.apache.hadoop.util.StopWatch) to remove direct log4j dependicies inherent in OpTimer.
Added scale method to provide conversion without truncation that is not in StopWatch.

----


> Refactor OpTimer so that it does not use log4j logger.
> ------------------------------------------------------
>
>                 Key: ACCUMULO-3840
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3840
>             Project: Accumulo
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 1.6.2, 1.7.0
>            Reporter: Ed Coleman
>            Assignee: Ed Coleman
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: ACCUMULO-3840-1.patch, ACCUMULO-3840.patch
>
>
> OpTimer currently uses log4j specific classes. OpTimer and the callers can be modified
so that log4j dependencies are not required.
> The evaluation of timer consolidation raised in ACCUMULO-3329 can still be performed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message