accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeffrey S Schwartz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3604) connector.instanceOperations().setSystemProperty(String,String) returns silently for non-changeable ZK Property's
Date Fri, 31 Jul 2015 15:38:04 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14649361#comment-14649361
] 

Jeffrey S Schwartz commented on ACCUMULO-3604:
----------------------------------------------

Guys,

Sorry for the delay in trying to get this patch resubmitted.

I made all the changes requested above and then re-ran all of the unit tests.

The MiniAccumuloClusterTest.testPerTableClasspath is now failing because the property "general.vfs.context.classpath.cx1"
does not have a valid PropertyType.regex.  This causes the call to p.getType().isValidFormat(value)
to always return false, which in turn (with the code changes) throws an IllegalArgumentException.

I'm trying to be mindful with the impact of the change vs the benefits of the code changes.

What are your thoughts?

> connector.instanceOperations().setSystemProperty(String,String) returns silently for
non-changeable ZK Property's
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-3604
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3604
>             Project: Accumulo
>          Issue Type: Bug
>          Components: master
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2
>            Reporter: Josh Elser
>            Assignee: Jeffrey S Schwartz
>              Labels: newbie, summit2015
>             Fix For: 1.8.0
>
>         Attachments: ACCUMULO-3604.patch
>
>
> Only a subset of the configuration {{Property}}'s in Accumulo are modifiable via ZooKeeper
(defined by {{Property.isValidZooProperty}}).
> {{connector.instanceOperations().setProperty(String,String)}} updates the provided property
name with the given value in ZooKeeper. The thing that is never mentioned is that only a subset
of the properties in Accumulo are allowed to be overriden in ZooKeeper. Furthermore, the user
receives no indication that their call failed.
> The Javadoc on {{setSystemProperty(String,String)}} should be updated to inform the users
that only some properties can be changed by this method, and some information should be returned
back to the user to let them know that their call did not succeed (likely an Exception).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message