Return-Path: X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5C0B180A1 for ; Fri, 12 Jun 2015 06:40:00 +0000 (UTC) Received: (qmail 71039 invoked by uid 500); 12 Jun 2015 06:40:00 -0000 Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org Received: (qmail 71001 invoked by uid 500); 12 Jun 2015 06:40:00 -0000 Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: jira@apache.org Delivered-To: mailing list notifications@accumulo.apache.org Received: (qmail 70990 invoked by uid 99); 12 Jun 2015 06:40:00 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Jun 2015 06:40:00 +0000 Date: Fri, 12 Jun 2015 06:40:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: notifications@accumulo.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ACCUMULO-3900) Incorrect precondition checking in AbstractEncoder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ACCUMULO-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583040#comment-14583040 ] ASF GitHub Bot commented on ACCUMULO-3900: ------------------------------------------ GitHub user dhutchis opened a pull request: https://github.com/apache/accumulo/pull/37 ACCUMULO-3900 Fix Lexicoder precondition check and bad test. This should do it. `offset + len == b.length` should be allowed, even when `len ==0`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dhutchis/accumulo ACCUMULO-3900 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/accumulo/pull/37.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #37 ---- commit 246129f1b2155f1abc4f8a0f2213a2f14aae6135 Author: Dylan Hutchison Date: 2015-06-12T00:12:08Z ACCUMULO-3900 Fix Lexicoder precondition check and bad test. ---- > Incorrect precondition checking in AbstractEncoder > -------------------------------------------------- > > Key: ACCUMULO-3900 > URL: https://issues.apache.org/jira/browse/ACCUMULO-3900 > Project: Accumulo > Issue Type: Bug > Components: client > Affects Versions: 1.7.0 > Reporter: Dylan Hutchison > Assignee: Dylan Hutchison > Priority: Trivial > Fix For: 1.7.1, 1.8.0 > > > In the method > {code}public T decode(byte[] b, int offset, int len){code} > the precondition > {code}offset + len < b.length{code} > should use {{<=}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)