Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: jira@apache.org
Date: Mon, 15 Jun 2015 14:21:00 +0000 (UTC)
From: "Eric Newton (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12702182.1395159727000.72415.1434378060631@Atlassian.JIRA>
In-Reply-To: <JIRA.12702182.1395159727000@Atlassian.JIRA>
References: <JIRA.12702182.1395159727000@Atlassian.JIRA>
 <JIRA.12702182.1395159727096@arcas>
Subject: [jira] [Commented] (ACCUMULO-2493) BinaryFormatter needs to be
 refactored
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/ACCUMULO-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14586096#comment-14586096 ] 

Eric Newton commented on ACCUMULO-2493:
---------------------------------------

Ideally, formatters would be stateless, except for some constant configuration.

I don't know what's up with that funky {{getlength}} method.

> BinaryFormatter needs to be refactored
> --------------------------------------
>
>                 Key: ACCUMULO-2493
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2493
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>            Reporter: Mike Drob
>            Assignee: Steve Blackmore
>              Labels: newbie
>
> BinaryFormatter is currently used in a couple places in the shell, but the code is hard to read and understand. There is a static getlength, which is actually a setter, and all the instance calls end up going through unnecessary static methods.
> This combination makes it hard to reuse BinaryFormatter objects, or even use multiple, since the static state is likely to conflict.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)