accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3925) Remove unnecessary warning messages from FATE ops
Date Mon, 29 Jun 2015 18:14:06 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14606044#comment-14606044
] 

Keith Turner commented on ACCUMULO-3925:
----------------------------------------

What about [FateServiceHandler.waitForTableOperation()|https://github.com/apache/accumulo/blob/414c140f58f8c0fcdf1740908b8c157a9523c8ed/server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java#L490]?
 I think it would get see a {{AcceptableFailureException}} which wraps a {{ThriftTableOperationException}}
and not handle that correctly.

Could have an interface instead of a class to avoid having to look at the cause.  Suppose
we created an interface called {{ExpectedException}} (note I used a different name based on
your javadoc for {{AcceptableFailureException}}, but I don't care what its named).  Could
do something like the following.

{code:java}
class ExpectedThriftTableOperationException extends ThriftTableOperationException implements
ExpectedException {
  public ExpectedThriftTableOperationException (ThriftTableOperationException e) {
    //clone expected exception
  }
}
{code}

Then code that wanted to throw a quiet ThriftTableOperationException could do the following.

{code:java}
  try {
    //...
  } catch (ThriftTableOperationException e) {
    throw new ExpectedThriftTableOperationException(e);
  }
{code}


> Remove unnecessary warning messages from FATE ops
> -------------------------------------------------
>
>                 Key: ACCUMULO-3925
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3925
>             Project: Accumulo
>          Issue Type: Improvement
>          Components: fate
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: ACCUMULO-3925.patch
>
>
> {noformat}
> Failed to execute Repo, tid=76367ba00e847e10
>     ThriftTableOperationException(tableId:null, tableName:ctt_000, op:CREATE, type:EXISTS,
description:null)
>         at org.apache.accumulo.master.tableOps.Utils.checkTableDoesNotExist(Utils.java:54)
>         at org.apache.accumulo.master.tableOps.PopulateZookeeper.call(PopulateZookeeper.java:54)
>         at org.apache.accumulo.master.tableOps.PopulateZookeeper.call(PopulateZookeeper.java:30)
>         at org.apache.accumulo.master.tableOps.TraceRepo.call(TraceRepo.java:57)
>         at org.apache.accumulo.fate.Fate$TransactionRunner.run(Fate.java:72)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>         at org.apache.accumulo.fate.util.LoggingRunnable.run(LoggingRunnable.java:35)
>         at java.lang.Thread.run(Thread.java:745) 
> {noformat}
> {noformat}
> Cannot move tables to a new namespace by renaming. The namespace for nspc_000.ctt_002
does not match ctt_001 
> {noformat}
> Lots of WARN messages seen during randomwalk that aren't system-level warning messages.
They are perfectly normal and expected. We should not be putting a warning to the monitor
for this messages. The exception thrown back to the client is sufficient.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message