accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3900) Incorrect precondition checking in AbstractEncoder
Date Fri, 12 Jun 2015 06:40:00 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583040#comment-14583040
] 

ASF GitHub Bot commented on ACCUMULO-3900:
------------------------------------------

GitHub user dhutchis opened a pull request:

    https://github.com/apache/accumulo/pull/37

    ACCUMULO-3900 Fix Lexicoder precondition check and bad test.

    
    This should do it.  `offset + len == b.length` should be allowed, even when `len ==0`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dhutchis/accumulo ACCUMULO-3900

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/accumulo/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #37
    
----
commit 246129f1b2155f1abc4f8a0f2213a2f14aae6135
Author: Dylan Hutchison <dhutchis@mit.edu>
Date:   2015-06-12T00:12:08Z

    ACCUMULO-3900 Fix Lexicoder precondition check and bad test.

----


> Incorrect precondition checking in AbstractEncoder
> --------------------------------------------------
>
>                 Key: ACCUMULO-3900
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3900
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.7.0
>            Reporter: Dylan Hutchison
>            Assignee: Dylan Hutchison
>            Priority: Trivial
>             Fix For: 1.7.1, 1.8.0
>
>
> In the method 
> {code}public T decode(byte[] b, int offset, int len){code}
> the precondition 
> {code}offset + len < b.length{code}
> should use {{<=}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message