accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (ACCUMULO-3900) Incorrect precondition checking in AbstractEncoder
Date Fri, 12 Jun 2015 06:19:00 GMT


ASF GitHub Bot commented on ACCUMULO-3900:

Github user ctubbsii commented on the pull request:
    Thanks for the patch. At first glance, it looked correct. However, it looks like this
causes some tests to fail with an ArrayIndexOutOfBounds failure. I haven't yet taken the time
to examine what is happening, but one possibility is that the tests are also wrong.
    If you have a chance to do update the patch with tests passing, @dhutchis , that would
be helpful.
    (Note: next time, if you put the issue number, ACCUMULO-3900 in the description / commit
message, asfbot will ensure a comment is made on the JIRA)

> Incorrect precondition checking in AbstractEncoder
> --------------------------------------------------
>                 Key: ACCUMULO-3900
>                 URL:
>             Project: Accumulo
>          Issue Type: Bug
>          Components: client
>    Affects Versions: 1.7.0
>            Reporter: Dylan Hutchison
>            Assignee: Dylan Hutchison
>            Priority: Trivial
>             Fix For: 1.7.1, 1.8.0
> In the method 
> {code}public T decode(byte[] b, int offset, int len){code}
> the precondition 
> {code}offset + len < b.length{code}
> should use {{<=}}

This message was sent by Atlassian JIRA

View raw message