accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3890) Use of CredentialProvider results in a lot of NN ops
Date Wed, 10 Jun 2015 21:29:01 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581114#comment-14581114
] 

Sean Busbey commented on ACCUMULO-3890:
---------------------------------------

{code}
+  private static final Map<String,List<Object>> cachedProviders = new HashMap<>();
+
{code}

Please add a comment that access should be synchronized on the class with an example of how
he static getCredentialProviders method is synchronized.

Are we worried about how this will perform? I don't have a feel for how often we're asking
for credentials, but it seems like if the number of RPCs to the NN was an issue having all
those same call battle over a monitor is going to be an issue. What about using a ThreadLocal
instead?

> Use of CredentialProvider results in a lot of NN ops
> ----------------------------------------------------
>
>                 Key: ACCUMULO-3890
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3890
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.1, 1.6.2, 1.7.0
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>             Fix For: 1.7.1, 1.8.0
>
>         Attachments: ACCUMULO-3890.1.patch, ACCUMULO-3890.2.patch, ACCUMULO-3890.3.patch,
ACCUMULO-3890.4.patch
>
>
> Every time we access a sensitive property or iterate over a configuration when there
is a CredentialProvider configured, it results in NN operations (as evidenced by FSNamesystem.audit
logs).  I think that we could assume the CredentialProvider is static, read its properties
once and cache them in memory to avoid these unnecessary reads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message