accumulo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (ACCUMULO-3890) Use of CredentialProvider results in a lot of NN ops
Date Wed, 10 Jun 2015 19:55:01 GMT

    [ https://issues.apache.org/jira/browse/ACCUMULO-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580994#comment-14580994
] 

Sean Busbey commented on ACCUMULO-3890:
---------------------------------------

{code}
+  private static Map<String,List<Object>> cachedProviders = new HashMap<>();
+
{code}

should be final

{code}
+    String path = conf.get(CREDENTIAL_PROVIDER_PATH);
+    if (path == null || path.isEmpty()) {
+      return null;
+    }
+
+    if (cachedProviders.containsKey(path)) {
+      return cachedProviders.get(path);
+    }
+
{code}

{code}
-      return (List<Object>) providersObj;
+      List<Object> providersList = (List<Object>) providersObj;
+      cachedProviders.put(path, providersList);
+      return providersList;
{code}

This cache implementation is not thread-safe, and it looks like the shim is attempting to
be thread-safe.

> Use of CredentialProvider results in a lot of NN ops
> ----------------------------------------------------
>
>                 Key: ACCUMULO-3890
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3890
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.6.1, 1.6.2, 1.7.0
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>             Fix For: 1.7.1, 1.8.0
>
>         Attachments: ACCUMULO-3890.1.patch, ACCUMULO-3890.2.patch, ACCUMULO-3890.3.patch
>
>
> Every time we access a sensitive property or iterate over a configuration when there
is a CredentialProvider configured, it results in NN operations (as evidenced by FSNamesystem.audit
logs).  I think that we could assume the CredentialProvider is static, read its properties
once and cache them in memory to avoid these unnecessary reads.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message