Return-Path: 
 <notifications-return-30523-apmail-accumulo-notifications-archive=accumulo.apache.org@accumulo.apache.org>
X-Original-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Delivered-To: apmail-accumulo-notifications-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8EF9417677
	for <apmail-accumulo-notifications-archive@minotaur.apache.org>;
 Wed, 27 May 2015 17:08:21 +0000 (UTC)
Received: (qmail 32709 invoked by uid 500); 27 May 2015 17:08:21 -0000
Delivered-To: apmail-accumulo-notifications-archive@accumulo.apache.org
Received: (qmail 32677 invoked by uid 500); 27 May 2015 17:08:21 -0000
Mailing-List: contact notifications-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@accumulo.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@accumulo.apache.org>
List-Post: <mailto:notifications@accumulo.apache.org>
List-Id: <notifications.accumulo.apache.org>
Reply-To: jira@apache.org
Delivered-To: mailing list notifications@accumulo.apache.org
Received: (qmail 32573 invoked by uid 99); 27 May 2015 17:08:21 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 May 2015 17:08:21 +0000
Date: Wed, 27 May 2015 17:08:21 +0000 (UTC)
From: "Josh Elser (JIRA)" <jira@apache.org>
To: notifications@accumulo.apache.org
Message-ID: <JIRA.12833107.1432746440000.40259.1432746501274@Atlassian.JIRA>
In-Reply-To: <JIRA.12833107.1432746440000@Atlassian.JIRA>
References: <JIRA.12833107.1432746440000@Atlassian.JIRA>
 <JIRA.12833107.1432746440917@arcas>
Subject: [jira] [Commented] (ACCUMULO-3854) [findbugs] AsyncSpanReceiver
 synchronizes a concurrent data structure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/ACCUMULO-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561286#comment-14561286 ] 

Josh Elser commented on ACCUMULO-3854:
--------------------------------------

ZooTraceClient does it too in 1.7.x

> [findbugs] AsyncSpanReceiver synchronizes a concurrent data structure
> ---------------------------------------------------------------------
>
>                 Key: ACCUMULO-3854
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-3854
>             Project: Accumulo
>          Issue Type: Bug
>    Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.6.0, 1.6.1, 1.6.2, 1.7.0
>            Reporter: Josh Elser
>            Priority: Minor
>              Labels: findbugs
>             Fix For: 1.8.0, 1.7.1
>
>
> Noticed this one playing around with ACCUMULO-3853
> If the type of {{sendQueue}} is switched to the concrete ConcurrentLinkedQueue instead of AbstractQueue, findbugs will catch this as an error because we synchronize on a concurrent data structure.
> {code}
> -  protected final AbstractQueue<RemoteSpan> sendQueue = new ConcurrentLinkedQueue<RemoteSpan>();
> +  protected final ConcurrentLinkedQueue<RemoteSpan> sendQueue = new ConcurrentLinkedQueue<RemoteSpan>();
> {code}
> Should trigger some findbugs warnings from the Maven build.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)